Polar plot method #183
Open
Polar plot method #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T to be more generic
Will need some input validation as well for the given dataset (e.g. make sure the angles are between 0-360 etc.)
Tom-Kingstone
added
status:WIP
Tom-Kingstone
removed
the
status:WIP
|
@BHoMBot check installer -force |
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
|
The check |
Tom-Kingstone
commented
Jul 10, 2025
|
@BHoMBot check installer -force |
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #179
moved polar plot method from LadybugTools_Toolkit to here. Also added ability to view the summed totals of values for use with plotting anything other than wind roses (for instance a radiation rose would be more useful to show total radiation from a direction, rather than the probability it happens), implemented through the
densitybool.The implementation is necessarily different to how it works in LBT (due to not being linked to a dataset through the Wind class), so data is input as a dataframe, and the method reads the values and directions columns specified.
Removed
other_dataas an input, as now that was a workaround for the Wind class to create roses from data that was not in the wind object itself (basically moving the polar plot method to Python_Toolkit made it redundant). See the linked LBT PR for more info.Renamed
other_binstovalue_bins(as it is easier to tell what it actually means this way)Test files
run the unit tests in LBT Toolkit
When unit tests for this method are made, run those as well.
Do a spot check with some openmeteo data in jupyter to check that it all works.
Changelog
LadybugTools_ToolkitAdditional comments